Skip to content

Allow using docker secrets for env variables#57

Merged
LeoColomb merged 2 commits intoYOURLS:masterfrom
jhollowe-forks:patch-1
Jun 24, 2020
Merged

Allow using docker secrets for env variables#57
LeoColomb merged 2 commits intoYOURLS:masterfrom
jhollowe-forks:patch-1

Conversation

@jhollowe
Copy link
Contributor

@jhollowe jhollowe commented Jun 23, 2020

copied in file_env() from the mysql entrypoint and added appropriate calls

not setting defaults, but could modify to set some defaults for the env vars.

closes #52

copied in file_env() from the mysql entrypoint and added appropriate calls
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, @jhollowe!
It's definitely going in the right direction. 👍

Few remarks as inline comments.

Co-authored-by: Léo Colombaro <git@colombaro.fr>
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks really good! Thanks again @jhollowe!

@LeoColomb LeoColomb merged commit e0b94b1 into YOURLS:master Jun 24, 2020
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 24, 2020
Changes:

- YOURLS/containers@45b26ce: Update to 1.7.9
- YOURLS/containers@e0b94b1: Allow using docker secrets for env variables (YOURLS/containers#57)
- YOURLS/containers@a8e13b5: Bump actions/checkout from v2.3.0 to v2.3.1
- YOURLS/containers@1ab4077: Bump actions/checkout from v2.2.0 to v2.3.0
- YOURLS/containers@de05e1f: Update dependabot.yml
- YOURLS/containers@06cf288: Bump actions/checkout from v1 to v2.2.0
- YOURLS/containers@e002ec4: Create Dependabot config file
- YOURLS/containers@fe07662: update PHP version and ran update.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow using Docker secrets for Environment Variables

2 participants