Repository navigation
fix(mobile): sending a prompt no longer turns the Android screen gray - #57
Merged
Merged
Conversation
pingdotgg#14850) (cherry picked from commit 42b5885)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android release builds, sending a prompt turned the whole screen gray, and the app stayed dead until it was force-closed.
Cause: when the composer shrinks after a send, keyboard-controller's Android deferred scroll calls
scrollViewRef()insiderequestAnimationFrame. Under Reanimated 4.7 the ref reaches the UI runtime as a shareable rather than a function, so the call throws and React Native destroys the React instance:Fix: cherry-picks upstream pingdotgg#14850 (original author kept). It reads the node from
scrollViewRef.valuewhen the ref is not a function. The fork synced to a stable tag before that fix landed.Verified on an Android 16 emulator against an isolated local server, sending a prompt from both an existing thread and the new-thread composer:
v0.0.45-dulli.4release APK: the crash above, gray screen.TypeError. The Reanimated warning still logs, but it's harmless.Made with Claude Opus 5.5 in the pi coding-agent harness