Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when player has no input device or microphone #962

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

thomeval
Copy link

@thomeval thomeval commented Feb 4, 2025

This PR adds a warning message to the Difficulty Select Screen when a non-bot player has no input devices assigned:
image

For vocalists, having no input device is considered valid. Instead, a different warning is displayed when a vocalist has no microphone connected:

image

Players without input devices are also shown differently on the Active Players list in the top status bar:

image

Note that icons used for this are placeholders and are identical to the regular instrument icons, except for the Vocals one.

@kaduwaengertner
Copy link
Member

We recently recreated all the instrument icons so they all match in style, so if you can update your PR to utilize the new ones that would be awesome, also sending the regular icons to be updated.

NoInstrumentIcons
InstrumentIcons

@thomeval
Copy link
Author

thomeval commented Feb 6, 2025

@kaduwaengertner Great, I've included those into this PR.

Copy link
Member

@EliteAsian123 EliteAsian123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again!

The code itself is fine, however, the anchoring positions of the UI elements are incorrect on certain resolutions:

image

Please see the "Loading Phrase" element in the same prefab to see how it can be fixed in this scenario. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants