Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vocal fixes #496

Merged
merged 15 commits into from
Jun 26, 2023
Merged

Vocal fixes #496

merged 15 commits into from
Jun 26, 2023

Conversation

EscapeNumber001
Copy link
Contributor

  • Vocal scoring now accounts for song speed, meaning FCs on sped-up songs should no longer be impossible.
  • The startSpeed, emission.rateOverTime, and startLifetime of vocal particles are all now adjusted based on track speed. Line particles should now show up correctly on higher track speeds.

@EscapeNumber001
Removed outdated todo comment
03d464c
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
52f516c
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
5765558
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
be9f218
@EscapeNumber001
Fixed Discord not accounting for speed changes
41f1a59
@EscapeNumber001
Formatting tweaks
910bf6c
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
a361d28
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
50cd719
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
161771d
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
918d03f
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
95f3ce9
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
51a6514
@EscapeNumber001
Merge branch 'dev' of https://github.com/YARC-Official/YARG into dev
73dcbdc
@EscapeNumber001
Fixed vocal performance with song speedups
296f138
@EscapeNumber001
Vocal particles now account for trackSpeed
01b144b
@EliteAsian123 EliteAsian123 merged commit 02b0601 into YARC-Official:dev Jun 26, 2023
@EscapeNumber001 EscapeNumber001 deleted the vocal_fixes branch June 26, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EscapeNumber001 @EliteAsian123