Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix songs not ending in rare cases, take 2 #455

Merged
merged 6 commits into from
Jun 11, 2023

Conversation

TheNathannator
Copy link
Collaborator

Let's try this again, shall we?

From the original PR:

Some songs (presumably with corrupt audio files) have reported lengths longer than BASS can play. Therefore the song's position never reached the supposed length and the gameplay never ended.

Instead of using the song position, it now uses SYNC events in BASS with callbacks. Probably not done in the nicest way but it did work in quick testing.

I have verified that the song that had issues reported ends correctly, and that other songs (including both .ini and CON songs) also end correctly.

@EliteAsian123 EliteAsian123 merged commit 6112b4f into YARC-Official:dev Jun 11, 2023
@TheNathannator TheNathannator deleted the song-end-event branch June 11, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants