Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement, reorganize, and fix a number of solo handling things #446

Merged
merged 11 commits into from
Jun 9, 2023

Conversation

TheNathannator
Copy link
Collaborator

Summary:

  • Solo phrases now have their note counts pre-calculated, and are now excluded if they contain no notes (overdrive phrases are also now excluded if they have no notes).
  • All text creation related to the solo box has been moved to TrackView, rather than the methods there accepting strings they take the actual values and turn those into strings themselves.
  • The solo score bonus has been re-added, along with displaying it after a solo.
  • The solo textbox is now colored again using the vertex colors that were present in the previous implementation. This time they've been turned into asset files, and can now be used on any other textbox if desired.
  • The previously commented-out code has been removed now that it's fully reimplemented.
  • Solos now wait for their first note to be the current note before starting.
  • A special result has been added for anyone who breaks solos again lol

@EliteAsian123 EliteAsian123 merged commit 731b252 into YARC-Official:dev Jun 9, 2023
@TheNathannator TheNathannator deleted the solo-fixes branch June 10, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants