-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1.0.6베타 QA 반영 #168
feat: 1.0.6베타 QA 반영 #168
Changes from 13 commits
d6f7e82
5358573
2cdb372
413a6be
c40312f
5bb5760
f2f1552
ef1fed7
9f38f1f
d9a5908
966ed1e
6744ed6
cc61760
9384699
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,11 +50,11 @@ public struct PokitSelect<Item: PokitSelectItem>: View { | |
} | ||
.onChange(of: selectedItem) { onChangedSeletedItem($0) } | ||
.sheet(isPresented: $showSheet) { | ||
listSheet | ||
.presentationDragIndicator(.visible) | ||
.pokitPresentationCornerRadius() | ||
.presentationDetents([.medium]) | ||
.pokitPresentationBackground() | ||
listSheet | ||
.presentationDragIndicator(.visible) | ||
.pokitPresentationCornerRadius() | ||
.presentationDetents([.height(564)]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 요거 se는 사이즈 괜찮았나요?? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 엇.. 확인 해보겠습니다.. 확인한다 해놓고 까먹고 있었,, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
.pokitPresentationBackground() | ||
} | ||
} | ||
|
||
|
@@ -115,7 +115,7 @@ public struct PokitSelect<Item: PokitSelectItem>: View { | |
listCellTapped(item) | ||
} | ||
} | ||
.padding(.top, 24) | ||
.padding(.top, 12) | ||
.padding(.bottom, 20) | ||
} else { | ||
PokitLoading() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유저마다 미분류 id값이 다르다면 저희가 할 수 있는 최선은 Constants로 빼내는것이긴 한데 ...
단순 문자열로 비교는 좀 별로긴하네요 서버쪽에서 해결해줘야 할 것 같아요..😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 어떻게 하면 좋을까여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 스테이..