Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-425] Common 모듈 분리 #37

Merged
merged 19 commits into from
Jan 31, 2025
Merged

Conversation

Lujaec
Copy link
Member

@Lujaec Lujaec commented Jan 30, 2025

🔗 관련 이슈

PC-425

✨ 작업 내용

  • common 모듈 분리

    • common:auth
    • common:domain
    • common:exception
    • common:format
  • infra 모듈 생성

    • infra:s3
    • infra:sms
    • infra:redis
  • common 모듈 이름 변경 (common => core)

    • core
    • core:auth
    • core:domain
    • core:exception
    • core:format
  • 모듈 패키지 이름 수정

    • 모듈에 적합하도록 해당 모듈의 이름을 패키지의 접두사에 포함 시켰습니다.

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

🎃 새롭게 알게된 사항

📋 참고 사항

  • 코드 리뷰 시 논의가 필요한 사항이나 배포 관련 주의 사항을 추가합니다.

@Lujaec Lujaec self-assigned this Jan 30, 2025
Copy link

Unit Test Results

1 tests   0 ✔️  0s ⏱️
1 suites  0 💤
1 files    1

For more details on these failures, see this check.

Results for commit 749e8b9.

@Lujaec Lujaec requested a review from devchlee12 January 30, 2025 12:27
Copy link
Member

@devchlee12 devchlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@Lujaec Lujaec merged commit c4f953a into develope Jan 31, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants