[PC-379] 어드민 모듈 로그인 기능 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devchlee12
approved these changes
Jan 23, 2025
Comment on lines
+10
to
+30
| public class AuthTokenGenerator { | ||
|
|
||
| private final JwtUtil jwtUtil; | ||
|
|
||
| @Value("${jwt.accessToken.expiration}") | ||
| private Long accessTokenExpiration; | ||
|
|
||
| @Value("${jwt.refreshToken.expiration}") | ||
| private Long refreshTokenExpiration; | ||
|
|
||
|
|
||
| public AuthToken generate(Long userId, String oauthId, String role) { | ||
| String accessToken = jwtUtil.createJwt("access_token", userId, oauthId, role, | ||
| accessTokenExpiration); | ||
|
|
||
| String refreshToken = jwtUtil.createJwt("refesh_token", userId, oauthId, role, | ||
| refreshTokenExpiration); | ||
|
|
||
| return new AuthToken(accessToken, refreshToken); | ||
| } | ||
| } |
| @@ -9,8 +9,10 @@ | |||
| @RequiredArgsConstructor | |||
| public enum AuthErrorCode implements ErrorCode { | |||
| OAUTH_ERROR(HttpStatus.FORBIDDEN, "Oauth Error"), | |||
| ACCESS_DENIED(HttpStatus.FORBIDDEN, "권한이 없습니다."), | |||
There was a problem hiding this comment.
에러 메시지 한글로 하는 거 좋은 것 같습니다!
앞으로는 에러메시지 한글로 할까요?
There was a problem hiding this comment.
에러 메시지가 한글인게 더 명확한 것 같습니다 !
그리고, 에러가 발생한 응답이 전달될때 클라이언트 분들은 저희 서비스만의 에러 코드(ex. 1404, 1402 ...)가 같이 전달되었으면 하는 바람이 있으신 것 같습니다. 한글로 변환하는 김에 저희 서비스 에러코드도 지정하는 것이 어떨까요 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
PC-379
✨ 작업 내용
✅ 체크리스트
🎃 새롭게 알게된 사항
📋 참고 사항
로그인하는 사용자를 위해 common:auth 모듈을 만들고 admin 모듈에서는 common:auth를 사용하도록 하였습니다.
토큰을 생성하는 로직을 api 모듈에서도 common:auth 기능을 사용하도록 수정해야합니다.