-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PC-270] 매칭 조각 확인 기능 구현 #30
Merged
devchlee12
merged 27 commits into
feature/PC-268-matching-algorithm
from
feature/PC-270-get-matching-piece
Jan 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
57cd332
[PC-270] feat: 매치 상태 ENUM 추가
devchlee12 1c8b517
[PC-270] feat: 가치관 픽 개체 Response 추가
devchlee12 a3a2978
[PC-270] feat: 가치관 픽 모음 조회 Response 추가
devchlee12 1110bfd
[PC-270] feat: 가치관 톡 개체 조회 Response 추가
devchlee12 92a3759
[PC-270] feat: 가치관 톡 모음 조회 Response 추가
devchlee12 8157d74
[PC-270] feat: 프로필 사진 Response 추가
devchlee12 4a35f24
[PC-270] feat: 매칭 정보 Response 추가
devchlee12 d321a3f
[PC-270] feat: 매칭 기본 프로필 조회 Response 추가
devchlee12 252150c
[PC-270] feat: 매칭 정보 조회 관련 로직 구현
devchlee12 48b715c
[PC-270] feat: 매칭 정보 확인 체크 메서드 추가
devchlee12 0ae130d
[PC-270] feat: 매칭 정보 조회 관련 API 엔드포인트들 추가
devchlee12 018e24e
[PC-271] feat: 매칭 수락 API 엔드포인트 추가
devchlee12 cc75ffb
[PC-271] feat: 매치 정보 엔티티 수락 메서드 추가
devchlee12 77ea7a0
[PC-271] feat: 매치 수락 기능 구현
devchlee12 ea94216
[PC-271] feat: 연락처 응답 객체 추가
devchlee12 1437ef1
[PC-271] fix: 연락처 응답 객체 수정
devchlee12 5abc497
[PC-271] fix: 연락처 응답 객체 수정
devchlee12 227b711
[PC-271] fix: 매칭 상대 연락처 조회 엔드포인트 추가
devchlee12 b44f0f7
[PC-271] fix: 매칭 수락 안됨 에러코드 추가
devchlee12 d69c3b1
[PC-271] feat: 매칭 상대 연락처 조회 API 엔드포인트 추가
devchlee12 fecc6bb
[PC-273] feat: 매칭 상대 차단 API 엔드포인트 추가
devchlee12 fde7c23
[PC-273] feat: 유저 직접 차단 및 차단 확인 기능 구현
devchlee12 18539e7
[PC-273] feat: 직접 차단 엔티티 추가
devchlee12 257bbd3
[PC-273] feat: 직접 차단 리포지토리 추가
devchlee12 e0ca328
[PC-273] feat: 유저 직접 차단기 구현
devchlee12 d36f2a4
Merge pull request #32 from YAPP-Github/feature/PC-273-match-blocking
devchlee12 02eebfb
Merge pull request #31 from YAPP-Github/feature/PC-271-accept-matching
devchlee12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
api/src/main/java/org/yapp/domain/match/presentation/dto/response/ImageUrlResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package org.yapp.domain.match.presentation.dto.response; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
@Getter | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class ImageUrlResponse { | ||
|
||
private String url; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url 하나만 Response 객체로 만든 이유가 있으실까요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json 형식으로 반환하는것이 PlainText로 반환하는 것보다 클라이언트가 사용할 때 편리할 것이라고 생각해서 Response 객체를 만들었습니다.
Map보다는 Response 객체를 만드는 것이 코드 통일성면이나 이후 확장성면에서 좋다고 생각합니다.