Bump windows crate range to 0.58-0.61#72
Merged
Xudong-Huang merged 2 commits intoXudong-Huang:masterfrom Jul 2, 2025
Merged
Conversation
8 tasks
Contributor
Author
|
@Xudong-Huang is this something you can look into? |
Contributor
Author
|
Also note that I haven't yet tested if this crate could take a version range on the |
MarijnS95
changed the title
windows crate to 0.59windows crate range to 0.58-0.59
MarijnS95
force-pushed
the
windows-0.59
branch
from
bb99244 to
e4afb28
Compare
This reverts commit 250f96a.
Because there were no breaking changes that affect this crate, the range could simply be extended to allow the new `windows 0.59` release in addition to `windows 0.58`, allowing our MSRV to stay unmodified (`windows 0.59` would have bumped it to `1.74` otherwise). However, such a should really be paired with a `-Zminimal-versions` or explicit downgrade in CI for testing though.
MarijnS95
changed the title
windows crate range to 0.58-0.59windows crate range to 0.58-0.61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/windows-rs/releases/tag/0.61.0
https://github.com/microsoft/windows-rs/releases/tag/63
Because there were no breaking changes that affect this crate, the range could simply be extended to allow the new
windows 0.59release in addition towindows 0.58, allowing our MSRV to stay unmodified (windows 0.59would have bumped it to1.74otherwise). However, such a should really be paired with a-Zminimal-versionsor explicit downgrade in CI for testing though.