Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call reservations with chosen address space instead of /24 #11

Closed
omerzubair opened this issue Mar 7, 2024 · 4 comments
Closed

Call reservations with chosen address space instead of /24 #11

omerzubair opened this issue Mar 7, 2024 · 4 comments

Comments

@omerzubair
Copy link

First of all thanks for providing this . it works fine and best part is when I want to decommission a vnet I can simply remove config and it will call the api and decommission and free up the slots from ipam solution. :)

Address Space
============

Currently you have config which allows to send size by using "size" i.e if I send 24 then I get carved out reservation of /24 from the block mentioned in api.

However, for my existing solution to work I need to send complete existing address space "10.71.26.0/23" to ipam solution and get the tag returned so that it is being tracked. I can do that manually by going to ipam solution interface, but it is against the automation have already have in AzDO pipelines.

Postman example:
============

Luckily after talking with @DCMattyG, there is an api already in ipam solution which when called with complete address space will do that work. Please if you can help update your provider with the same capability as the api. that would be awesome .

image
@omerzubair
Copy link
Author

Hi Team,
I am actively working on this. can this be acknowledged please?
Happy to test this for feedback immediately.
cheers

@XtratusCloud
Copy link
Owner

H @omerzubair,
We have pending to analyze the last changes added to the azureipam solution to transfer them to the provider, and probably this is one of them, we will take it into consideration.

This is an opensource project, and the changes and improvements are made in our free time, you must understand that it will not be finished in a few days.

Regards,

@omerzubair
Copy link
Author

thanks for the reply. Eagerly awaiting :)

fnietoga added a commit that referenced this issue Sep 14, 2024
@fnietoga
#11 added azureipam_reservation_cidr to allow to specify cidr to reserve
e930c92
XtratusCloud pushed a commit that referenced this issue Sep 21, 2024
@fnietoga
Feat/new resources (#13)
80f8936 
* examples by resource folder

* last go and goreleaser versions

* Implemented tfplugindocs for doc auto-generation

* Added data source for spaces

* added spaces datasource doc

* migrated from sdkv2 to terraform framework

* sdkv2 to framework migration, date and null management

* prepare for debug

* avoid reservation redeploy after import

* added acceptance tests

* added space resource with acc tests

* review doc and templates

* added local  tests for ent-to-end functionality check

* updated release workflow, added test workflow

* fixed time comparissons in tests

* added skip_cert_verification provider attribute

* changes in reverse_search and smallest_cidr requires to enforce replacement

* added block resource

* added blocks data resource

* added external network resource

* files renamed

* added RequiresReplace in resource some schemas

* #7 allow to specify a block list in reservation

* skip_cert_verification false by default

* #11 added azureipam_reservation_cidr to allow to specify cidr to reserve

* added azureipam_external data source

* added azureipam_block data source

* added azureipam_space data source

* added azureipam_reservation data source

* implemented azureipam_block_network resource

* dummyfied all tenant and subscription ids

* implemented azureipam_block_networks_availables data source

* added azureipam_block_networks data source

* updated README
XtratusCloud added a commit that referenced this issue Sep 21, 2024
@XtratusCloud @fnietoga
Added all Azure IPAM REST API functionality (#14)
6754b84 
* examples by resource folder

* last go and goreleaser versions

* Implemented tfplugindocs for doc auto-generation

* Added data source for spaces

* added spaces datasource doc

* migrated from sdkv2 to terraform framework

* sdkv2 to framework migration, date and null management

* prepare for debug

* avoid reservation redeploy after import

* added acceptance tests

* added space resource with acc tests

* review doc and templates

* added local  tests for ent-to-end functionality check

* updated release workflow, added test workflow

* fixed time comparissons in tests

* added skip_cert_verification provider attribute

* changes in reverse_search and smallest_cidr requires to enforce replacement

* added block resource

* added blocks data resource

* added external network resource

* files renamed

* added RequiresReplace in resource some schemas

* #7 allow to specify a block list in reservation

* skip_cert_verification false by default

* #11 added azureipam_reservation_cidr to allow to specify cidr to reserve

* added azureipam_external data source

* added azureipam_block data source

* added azureipam_space data source

* added azureipam_reservation data source

* implemented azureipam_block_network resource

* dummyfied all tenant and subscription ids

* implemented azureipam_block_networks_availables data source

* added azureipam_block_networks data source

* updated README

---------

Co-authored-by: Francisco Nieto <[email protected]>
@XtratusCloud
Copy link
Owner

Implemented in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omerzubair @XtratusCloud