Yaml support #10
Yaml support #10
Conversation
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Created by kylehansen @Sypticus on 12/28/16. |
There was a problem hiding this comment.
Lets make this javadoc relevant -- a good candidate would be at least a link to the doc page mentioning the YAML format.
| /** | ||
| * Created by kylehansen @Sypticus on 12/28/16. | ||
| */ | ||
| @Data |
| import java.util.stream.Collectors; | ||
| /** | ||
| * Created by kylehansen @Sypticus on 12/28/16. | ||
| */ |
There was a problem hiding this comment.
Ditto on Javadoc, just a little bit about why it exists.
| //Defined in Yaml | ||
| } | ||
| rpc TestMethod5 (TestRequest) returns (TestResponse) { | ||
| //Defined in Yaml |
There was a problem hiding this comment.
Comments are inconsistent spacing.
| if(rule.getSelector().equals(fullMethodName) || rule.getSelector().equals("*")){ //TODO: com.foo.* | ||
| //YAML http rules override proto files. - https://cloud.google.com/endpoints/docs/grpc-service-config | ||
| DescriptorProtos.MethodOptions yamlOptions = DescriptorProtos.MethodOptions.newBuilder().setExtension(AnnotationsProto.http, rule.buildHttpRule()).build(); | ||
| methodProto = DescriptorProtos.MethodDescriptorProto.newBuilder().mergeFrom(methodProto).setOptions(yamlOptions).build(); |
There was a problem hiding this comment.
This lines are really really long, I'd like to keep it at ~120 chars.
| @@ -85,6 +83,16 @@ | |||
| for(Descriptors.ServiceDescriptor serviceDescriptor : fd.getServices()) { | |||
| DescriptorProtos.ServiceDescriptorProto serviceDescriptorProto = serviceDescriptor.toProto(); | |||
| for(DescriptorProtos.MethodDescriptorProto methodProto : serviceDescriptorProto.getMethodList()) { | |||
| String fullMethodName = serviceDescriptor.getFullName() +"." + methodProto.getName(); | |||
| if(yamlConfig.isPresent()){ //Check to see if the rules are defined in the YAML | |||
| for(YamlHttpRule rule :yamlConfig.get().getRules()){ | |||
There was a problem hiding this comment.
Space after : -- I also noticed that most lines are lacking a space between ) and {. I don't have a problem with it in spirit, but I would like to keep the style consistent.
|
Done |
|
One last comment remaining on a Javadoc |
|
Changes were below you marker. But cleaned them up further. |
Now allowing httpRules to be defined in a YAML file instead of the .proto files.