Skip to content

Commit

Permalink
[MXNET-645] Add flakiness checker (apache#11572)
Browse files Browse the repository at this point in the history
* add flakiness checker

* fixed style and argument parsing

* added verbosity option, further documentation, etc.

* added logging

* Added check for invalid argument

* updated error message for specificity

* fixed help message
  • Loading branch information
cetsai authored and marcoabreu committed Jul 24, 2018
1 parent 43b5b49 commit f42e839
Showing 1 changed file with 112 additions and 0 deletions.
112 changes: 112 additions & 0 deletions tools/flakiness_checker.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

""" Checks a given test for flakiness
Takes the file name and function name of a test, as well as, optionally,
the number of trials to run and the random seed to use
"""

import subprocess
import sys
import os
import random
import argparse
import re
import logging

logging.basicConfig(level=logging.INFO)

DEFAULT_NUM_TRIALS = 10000
DEFAULT_VERBOSITY = 2

def run_test_trials(args):
test_path = args.test_path + ":" + args.test_name
logging.info("Testing: %s", test_path)

new_env = os.environ.copy()
new_env["MXNET_TEST_COUNT"] = str(args.num_trials)

if args.seed is None:
logging.info("No test seed provided, using random seed")
else:
new_env["MXNET_TEST_SEED"] = str(args.seed)

verbosity = "--verbosity=" + str(args.verbosity)

code = subprocess.call(["nosetests", verbosity, test_path],
env = new_env)

logging.info("Nosetests terminated with exit code %d", code)

def find_test_path(test_file):
"""Searches for the test file and returns the path if found
As a default, the currend working directory is the top of the search.
If a directory was provided as part of the argument, the directory will be
joined with cwd unless it was an absolute path, in which case, the
absolute path will be used instead.
"""
test_file += ".py"
test_path = os.path.split(test_file)
top = os.path.join(os.getcwd(), test_path[0])

for (path, dirs, files) in os.walk(top):
if test_path[1] in files:
return os.path.join(path, test_path[1])
raise FileNotFoundError("Could not find " + test_path[1] +
"in directory: " + top)

class NameAction(argparse.Action):
"""Parses command line argument to get test file and test name"""
def __call__(self, parser, namespace, values, option_string=None):
name = re.split("\.py:|\.", values)
if len(name) != 2:
raise ValueError("Invalid argument format for test. Format: "
"<file-name>.<test-name> or"
" <directory>/<file>:<test-name>")
setattr(namespace, "test_path", find_test_path(name[0]))
setattr(namespace, "test_name", name[1])

def parse_args():
parser = argparse.ArgumentParser(description="Check test for flakiness")

parser.add_argument("test", action=NameAction,
help="file name and and function name of test, "
"provided in the format: <file-name>.<test-name> "
"or <directory>/<file>:<test-name>")

parser.add_argument("-n", "--num-trials", metavar="N",
default=DEFAULT_NUM_TRIALS, type=int,
help="number of test trials, passed as "
"MXNET_TEST_COUNT, defaults to 500")

parser.add_argument("-s", "--seed", type=int,
help="test seed, passed as MXNET_TEST_SEED, "
"defaults to random seed")

parser.add_argument("-v", "--verbosity",
default=DEFAULT_VERBOSITY, type=int,
help="logging level, passed to nosetests")


args = parser.parse_args()
return args


if __name__ == "__main__":
args = parse_args()

run_test_trials(args)

0 comments on commit f42e839

Please sign in to comment.