Skip to content

Commit

Permalink
Disable flaky tests (apache#11440)
Browse files Browse the repository at this point in the history
* Disable tests

* Disable kvstore test

* Unify unittest and integration test stage

* Add new disabled test
  • Loading branch information
marcoabreu authored Jun 28, 2018
1 parent fcb49c5 commit a917bb9
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 18 deletions.
34 changes: 16 additions & 18 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ try {
}
} // End of stage('Build')

stage('Unit Test') {
stage('Tests') {
parallel 'Python2: CPU': {
node('mxnetlinux-cpu') {
ws('workspace/ut-python2-cpu') {
Expand Down Expand Up @@ -887,11 +887,8 @@ try {
}
}
}
}
}

stage('Integration Test') {
parallel 'Onnx CPU': {
},
'Onnx CPU': {
node('mxnetlinux-cpu') {
ws('workspace/it-onnx-cpu') {
timeout(time: max_time, unit: 'MINUTES') {
Expand Down Expand Up @@ -948,19 +945,20 @@ try {
}
}
}
},
'dist-kvstore tests GPU': {
node('mxnetlinux-gpu') {
ws('workspace/it-dist-kvstore') {
timeout(time: max_time, unit: 'MINUTES') {
init_git()
unpack_lib('gpu')
docker_run('ubuntu_gpu', 'integrationtest_ubuntu_gpu_dist_kvstore', true)
publish_test_coverage()
}
}
}
}
// Disable until fixed https://github.com/apache/incubator-mxnet/issues/11441
// 'dist-kvstore tests GPU': {
// node('mxnetlinux-gpu') {
// ws('workspace/it-dist-kvstore') {
// timeout(time: max_time, unit: 'MINUTES') {
// init_git()
// unpack_lib('gpu')
// docker_run('ubuntu_gpu', 'integrationtest_ubuntu_gpu_dist_kvstore', true)
// publish_test_coverage()
// }
// }
// }
//}
}

stage('Deploy') {
Expand Down
4 changes: 4 additions & 0 deletions tests/python/gpu/test_operator_gpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ def check_countsketch(in_dim,out_dim,n):
a[j,i] = out_grad.asnumpy()[j, h[0,i]] * s[0,i]
assert_almost_equal(a,arr_grad[0].asnumpy(),rtol=1e-3, atol=1e-12)


@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/10988")
@with_seed(0)
def test_countsketch():
nrepeat = 2
Expand Down Expand Up @@ -460,6 +462,8 @@ def check_consistency_NxM(sym_list, ctx_list):
# sym_list=[sym1, sym1, sym1, sym2, sym2, sym2] and ctx_list=[ctx1, ctx2, ctx3, ctx1, ctx2, ctx3]
check_consistency(np.repeat(sym_list, len(ctx_list)), ctx_list * len(sym_list))


@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/10141")
@with_seed()
def test_convolution_options():
# 1D convolution
Expand Down
1 change: 1 addition & 0 deletions tests/python/unittest/test_gluon.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ def check_layer_forward(layer, dshape):
mx.test_utils.assert_almost_equal(np_out, out.asnumpy(), rtol=1e-5, atol=1e-6)
mx.test_utils.assert_almost_equal(np_dx, x.grad.asnumpy(), rtol=1e-5, atol=1e-6)

@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/11395")
@with_seed()
def test_conv():
layers1d = [
Expand Down
4 changes: 4 additions & 0 deletions tests/python/unittest/test_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ def test_rnnrelu_sym():
check_rnn_consistency(fused, stack, T, N, I, H, 'add')
check_rnn_consistency(fused, stack, T, N, I, H, 'null')


@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/11410")
@with_seed()
def test_rnnrelu_bidirectional():
T, N, I, H = 5, 20, 200, 200
Expand Down Expand Up @@ -1289,6 +1291,7 @@ def check_deconvolution_target_shape(input_shape, kernel, stride, pad, adj, targ
assert out_shapes[0] == (input_shape[0], 5) + target_shape


@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/10973")
@with_seed()
def test_deconvolution():
# 2D
Expand Down Expand Up @@ -5476,6 +5479,7 @@ def check_dropout_axes(ratio, shape, axes):
check_dropout_axes(0.25, nshape, axes = (1, 2, 3))


@unittest.skip("test fails intermittently. temporarily disabled till it gets fixed. tracked at https://github.com/apache/incubator-mxnet/issues/11290")
@with_seed()
def test_scatter_gather_nd():
def check(data, idx):
Expand Down

0 comments on commit a917bb9

Please sign in to comment.