Skip to content

whisper: remove package whisper#687

Merged
gzliudan merged 5 commits intoXinFinOrg:dev-upgradefrom
JukLee0ira:whisper
Nov 13, 2024
Merged

whisper: remove package whisper#687
gzliudan merged 5 commits intoXinFinOrg:dev-upgradefrom
JukLee0ira:whisper

Conversation

@JukLee0ira
Copy link
Copy Markdown

@JukLee0ira JukLee0ira commented Oct 23, 2024

Proposed changes

Reference:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement
  • N/A

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Comment thread cmd/XDC/config.go Outdated
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory whisper/whisperv5/ is not removed.

@gzliudan gzliudan changed the title whisper: remove whisper whisper: remove package whisper Nov 13, 2024
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove others about whisper according to below geth PR:

@gzliudan gzliudan merged commit 6459d0c into XinFinOrg:dev-upgrade Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants