Skip to content

change TxPreEvent to TxsPreEvent#495

Merged
gzliudan merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:TxPreEvent
Apr 1, 2024
Merged

change TxPreEvent to TxsPreEvent#495
gzliudan merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:TxPreEvent

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Mar 18, 2024

Proposed changes

This PR is from all: change TxPreEvent to TxsPreEvent with minor modifications, below is the original description:

Currently, when a transaction is promoted, a TxPreEvent will be pushed to subscribers immediately.

While when the number of new transactions received is large, there are too many TxPreEvent will be pushed leads to txFeed lock resource contention.

So this PR replace all TxPreEvent to TxsPreEvent. So that we can push a batch of new promoted txs together. It will help in these scenario:

  • Block reorganization(a bunch of transactions will be re-injected to txpool)
  • Improve transaction forwarding efficiency(Send a batch of transactions to peers instead of single one)
  • Relieving pressure on the system from websocket pending transaction subscriptions(Prevent slower socket write speeds from blocking txfeed)

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copy link
Copy Markdown
Collaborator

@liam-lai liam-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gzliudan gzliudan merged commit 7c8317a into XinFinOrg:dev-upgrade Apr 1, 2024
@gzliudan gzliudan deleted the TxPreEvent branch April 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants