fix(eth/gasestimator,internal/ethapi): fix block overrides in estimate gas #34081#2265
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Refactors DoEstimateGas to use a single effective block header after applying BlockOverrides, ensuring gas estimation options and transaction defaults are derived from the same header context.
Changes:
- Remove the separate
estimationHeaderalias and reuseheaderafter applyingblockOverrides. - Use the overridden
headerconsistently forgasestimator.Options,CallDefaults, andToMessage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0b766b4 to
b3b9e44
Compare
b3b9e44 to
b208449
Compare
…e gas ethereum#34081 Align estimateGas with the geth backport by consistently using the block-overridden header for CallDefaults, ToMessage, and gas estimator options. Drop estimator-side block override plumbing and cap the search upper bound to MaxTxGas when Osaka rules are active (EIP-7825), preventing oversized estimates under Osaka.
b208449 to
ff63434
Compare
Proposed changes
Align estimateGas with the geth backport by consistently using the block-overridden header for CallDefaults, ToMessage, and gas estimator options.
Drop estimator-side block override plumbing and cap the search upper bound to MaxTxGas when Osaka rules are active (EIP-7825), preventing oversized estimates under Osaka.
Ref: ethereum#34081
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that