fix(core/txpool): initialize journal writer for tx tracker #32921

[gzliudan]

Proposed changes

Ref: ethereum#32921

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 37f67b18-be1d-409d-a41d-5f5bf122ebf8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR aims to fix local transaction journaling reliability in the txpool locals tracker by ensuring the journal writer is initialized, and adds tests around tracker resubmission/journaling behavior.

Changes:

• Initialize the local tx journal writer during TxTracker startup so TrackAll insertions can be persisted.
• Refactor TxTracker.recheck to handle journal rotation internally (while holding the tracker lock).
• Add a new TxTracker unit test file covering resubmission and journaling scenarios.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
core/txpool/txpool.go	Moves SetSigner/IsSigner methods (no functional change).
core/txpool/locals/tx_tracker.go	Refactors recheck return values; initializes journal writer in the tracker loop; adjusts periodic rejournal logic.
core/txpool/locals/journal.go	Adds setupWriter() to open the journal for appends outside of rotate().
core/txpool/locals/tx_tracker_test.go	Introduces new tests for tracker resubmission and journal persistence.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Fixes local transaction tracker journaling startup so the journal writer is initialized before the tracker begins accepting tracked transactions, preventing early Track/TrackAll calls from failing to persist.

Changes:

• Move journal loading to TxTracker.Start() and initialize the journal writer before returning.
• Simplify recheck to return only resubmits and perform journal rotation internally while holding the tracker lock.
• Update/add tests to validate journaling behavior and that Start() initializes the journal writer.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
core/txpool/locals/tx_tracker.go	Initializes journal writer during Start, adjusts recheck/loop journaling flow.
core/txpool/locals/journal.go	Adds setupWriter() helper to (re)open the journal append writer.
core/txpool/locals/tx_tracker_test.go	Updates resubmit assertions and adds journaling + startup writer initialization tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.