fix(p2p): fix websocket log line parsing in exec p2p/simulations adapter #16667

[gzliudan]

Proposed changes

Ref: ethereum#16667

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request fixes a bug in the WebSocket log line parsing for the p2p/simulations exec adapter. The issue was that the code was looking for a log message with "WebSocket endpoint opened:" (with a colon), but the actual log message produced by the node is "WebSocket endpoint opened" (without a colon). This caused the exec adapter to timeout when trying to start nodes in simulations.

Changes:

• Fixed the WebSocket endpoint log message string matching to remove the incorrect colon
• Refactored the WebSocket address parsing logic into a separate file (ws.go) for better code organization
• Added test coverage for the WebSocket address parsing functionality

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
p2p/simulations/adapters/ws.go	New file containing extracted WebSocket address parsing logic with the bug fix
p2p/simulations/adapters/ws_test.go	New test file validating the WebSocket address parsing functionality
p2p/simulations/adapters/exec.go	Refactored to use the extracted functions, removing inline WebSocket parsing code

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.