Skip to content

core/types: remove unused var ErrInvalidTxType #32989#1682

Closed
wit765 wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
wit765:remove-ErrInvalidTxType
Closed

core/types: remove unused var ErrInvalidTxType #32989#1682
wit765 wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
wit765:remove-ErrInvalidTxType

Conversation

@wit765
Copy link
Copy Markdown

@wit765 wit765 commented Oct 26, 2025

Proposed changes

remove unused var ErrInvalidTxType in the file core/types/transaction.go

Ref: ethereum#32989

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title core/types: remove unused var #32989 core/types: remove unused var ErrInvalidTxType #32989 Oct 26, 2025
@wit765 wit765 force-pushed the remove-ErrInvalidTxType branch from 6c07bd0 to e0cb091 Compare October 26, 2025 02:31
@wit765 wit765 closed this Nov 9, 2025
@wit765 wit765 deleted the remove-ErrInvalidTxType branch November 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants