Skip to content

crypto/bn256: switch to gnark again #32659#1552

Merged
gzliudan merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:gnark-default
Sep 23, 2025
Merged

crypto/bn256: switch to gnark again #32659#1552
gzliudan merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:gnark-default

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Ref: ethereum#32659

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

We recently update our default implementation to gnark in
ethereum#32024
Then we found a consensus issue and reverted it in
ethereum@65d77c5
We fixed the consensus issue and have been fuzzing it more since then in
https://github.com/ethereum/go-ethereum/pull/32055/files
ethereum#32065
https://github.com/ethereum/go-ethereum/pull/32055/files

So I think now is the time to update it back to gnark
@gzliudan gzliudan merged commit 2826b1e into XinFinOrg:dev-upgrade Sep 23, 2025
12 checks passed
@gzliudan gzliudan deleted the gnark-default branch September 23, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants