Skip to content

crypto/bn256/gnark: align marshaling behavior #32065#1231

Merged
gzliudan merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:bn256-marshalling
Aug 20, 2025
Merged

crypto/bn256/gnark: align marshaling behavior #32065#1231
gzliudan merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:bn256-marshalling

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Ref: ethereum#32065

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title crypto/bn256/gnark: align marshaling behavior #32065 [WIP] crypto/bn256/gnark: align marshaling behavior #32065 Jul 15, 2025
Aligns the marshaling behavior of gnark to google and cloudflare

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@gzliudan gzliudan force-pushed the bn256-marshalling branch from 6ebc1c4 to 499bff1 Compare August 8, 2025 03:38
@gzliudan gzliudan changed the title [WIP] crypto/bn256/gnark: align marshaling behavior #32065 crypto/bn256/gnark: align marshaling behavior #32065 Aug 8, 2025
@gzliudan gzliudan merged commit 6b31ded into XinFinOrg:dev-upgrade Aug 20, 2025
12 checks passed
@gzliudan gzliudan deleted the bn256-marshalling branch August 20, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants