trie: update func ForEachWithOrder #27496 #27909

[gzliudan]

Proposed changes

Ref:

• tests, trie: use slices package for sorting ethereum/go-ethereum#27496
• all: update golang/x/ext and fix slice sorting fallout ethereum/go-ethereum#27909

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Refactors trie node iteration ordering code, aiming to move sorting to the Go slices package (per PR title / referenced issues).

Changes:

• Updates NodeSet.ForEachWithOrder to collect paths into a []string and sort them in reverse order via sort.StringSlice conversion.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wanwiset25]

agree with copilot
https://github.com/XinFinOrg/XDPoSChain/pull/1163/changes#r2726564857

[gzliudan]

agree with copilot https://github.com/XinFinOrg/XDPoSChain/pull/1163/changes#r2726564857

PR ethereum#27496 change:

        sort.Sort(sort.Reverse(paths))

to

        slices.SortFunc(paths, func(a, b string) bool {
		return a > b // Sort in reverse order
	})

then PR ethereum#27909 change it to sort.Sort(sort.Reverse(sort.StringSlice(paths))) again.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.