Skip to content

trie: wrap deletion in case trie.root is nil #26365#1124

Merged
AnilChinchawale merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:fix-commit
Nov 17, 2025
Merged

trie: wrap deletion in case trie.root is nil #26365#1124
AnilChinchawale merged 1 commit into
XinFinOrg:dev-upgradefrom
gzliudan:fix-commit

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Ref: ethereum#26365

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title trie: wrap deletion in case trie.root is nil #26365 [WIP] trie: wrap deletion in case trie.root is nil #26365 Jun 19, 2025
This PR fixes an error in trie commit. If the trie.root is nil, it can be two possible scenarios:

-  The trie was empty, and no change happens
-  The trie was non-empty and all nodes are dropped

For the latter one, we should collect the deletions and apply them into database(e.g. in PBSS).
@gzliudan gzliudan changed the title [WIP] trie: wrap deletion in case trie.root is nil #26365 trie: wrap deletion in case trie.root is nil #26365 Nov 13, 2025
@AnilChinchawale AnilChinchawale merged commit a4fbda2 into XinFinOrg:dev-upgrade Nov 17, 2025
12 checks passed
@gzliudan gzliudan deleted the fix-commit branch November 17, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants