Skip to content

trie: implement NodeBlob API for trie iterator #24391 #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gzliudan merged 1 commit into from
Aug 20, 2025
Merged

trie: implement NodeBlob API for trie iterator #24391 #1084

gzliudan merged 1 commit into from
Aug 20, 2025

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jun 6, 2025

Proposed changes

Ref: ethereum#24391

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title trie: implement NodeBlob API for trie iterator #24391 [WIP] trie: implement NodeBlob API for trie iterator #24391 Jun 6, 2025
@rjl493456442 @gzliudan
trie: implement NodeBlob API for trie iterator ethereum#24391
129b95c 
This functionality is needed in new path-based storage scheme, but
can be implemented in a seperate PR though.

When an account is deleted, then all the storage slots should be
nuked out from the disk as well. In hash-based storage scheme they
are still left in the disk but in new scheme, they will be iterated
and marked as deleted.

But why the NodeBlob API is needed in this scenario? Because when
the node is marked deleted, the previous value is also required to
be recorded to construct the reverse diff.
@gzliudan gzliudan changed the title [WIP] trie: implement NodeBlob API for trie iterator #24391 trie: implement NodeBlob API for trie iterator #24391 Aug 20, 2025
@gzliudan gzliudan merged commit a8b841c into XinFinOrg:dev-upgrade Aug 20, 2025
10 checks passed
@gzliudan gzliudan deleted the trie-iterator branch August 20, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

@AnilChinchawale AnilChinchawale Awaiting requested review from AnilChinchawale

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gzliudan @benjamin202410 @rjl493456442