Skip to content

internal/web3ext: remove deprecated debug api#1031

Merged
gzliudan merged 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:fix-backtraceAt
May 8, 2025
Merged

internal/web3ext: remove deprecated debug api#1031
gzliudan merged 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:fix-backtraceAt

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented May 8, 2025

Proposed changes

This PR cleans the file web3ext.go, removes deprecated JSONRPC APIs:

  • debug_backtraceAt
  • debug_setMutexProfileRate

The function BacktraceAt has been removed in PR #734 and ethereum#28187.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title web3ext: remove debug api backtraceAt internal/web3ext: remove debug api backtraceAt May 8, 2025
@gzliudan gzliudan force-pushed the fix-backtraceAt branch from c558dfc to feed186 Compare May 8, 2025 06:18
@gzliudan gzliudan changed the title internal/web3ext: remove debug api backtraceAt internal/web3ext: remove debug_backtraceAt and debug_setMutexProfileRate May 8, 2025
@gzliudan gzliudan changed the title internal/web3ext: remove debug_backtraceAt and debug_setMutexProfileRate internal/web3ext: remove debug api backtraceAt and setMutexProfileRate May 8, 2025
@gzliudan gzliudan changed the title internal/web3ext: remove debug api backtraceAt and setMutexProfileRate internal/web3ext: remove deprecated debug api May 8, 2025
@gzliudan gzliudan merged commit c70186b into XinFinOrg:dev-upgrade May 8, 2025
13 checks passed
@gzliudan gzliudan deleted the fix-backtraceAt branch May 8, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants