Closed
Conversation
Collaborator
Author
|
In utils/clone-llvm.sh the branch used is the 'air' branch. Why is this? When I bump, can I use main? |
Collaborator
|
I suggest bumping mlir-aie at the same time and using the LLVM hash here: https://github.com/Xilinx/mlir-aie/blob/main/utils/clone-llvm.sh#L16. The llvm version for mlir-aie and mlir-air should match. |
Collaborator
It's naming the local branch |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This focuses on the LLVM bump. Mostly related to the SCF ReduceOp changes in llvm/llvm-project#75314
As a follow-up we can bump the mlir-aie used. I just first want to see if this PR actually works (I haven't built and tested succesfully locally).