-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Advanced Configuration and Initial Translations #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an "Advanced Configuration Options" step to the config flow. - Moved `action_debug` and `hide_non_standard_entities` configurations to the new step. - Introduced a checkbox "Show Advanced Configuration Options" in the devices filter form. - Only show the advanced step if the user opts in via the checkbox. This change enhances the configuration process by allowing users to access advanced settings only if needed, keeping the initial setup simple.
…hinese Simplified/Chinese Traditional.
…PT-BR, RU, and Traditional Chinese. These translations were generated using Tongyi Lingma and may require further verification to ensure accuracy. Contributions for reviewing and improving these translations are highly appreciated.
# Conflicts: # custom_components/xiaomi_home/config_flow.py
- Shortened lines in custom_components/xiaomi_home/config_flow.py to comply with PEP 8's line length limit (80 characters). - Addressed pylint warnings concerning line lengths on lines 489, 568, and 569.
c997f22
to
d8e6c45
Compare
This function has been merged in #332, and thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the configuration flow in the Xiaomi Home Assistant integration by including an "Advanced Configuration Options" step and adds initial translations for the new settings.
Key Changes:
action_debug
andhide_non_standard_entities
after opting in on the devices filter form with a new checkbox.Welcome community contributors to review and refine these translations, especially those generated by Tongyi Lingma, to ensure their precision and clarity. Your feedback is invaluable in improving the user experience for non-English speakers.
This update aims to streamline the setup process and improve multilingual accessibility, benefiting a diverse range of users.