Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Advanced Configuration and Initial Translations #191

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JimmyKmi
Copy link

This pull request enhances the configuration flow in the Xiaomi Home Assistant integration by including an "Advanced Configuration Options" step and adds initial translations for the new settings.

Key Changes:

  • Introduced the "Advanced Configuration Options" step, enabling users to set action_debug and hide_non_standard_entities after opting in on the devices filter form with a new checkbox.
  • Provided translations for the new configuration options:
    • English, French, Simplified Chinese, and Traditional Chinese translations were done manually.
    • Translations for German (DE), Spanish (ES), Japanese (JA), Portuguese (PT), Brazilian Portuguese (PT-BR), and Russian (RU) were generated using Tongyi Lingma and should be verified for accuracy.

Welcome community contributors to review and refine these translations, especially those generated by Tongyi Lingma, to ensure their precision and clarity. Your feedback is invaluable in improving the user experience for non-English speakers.


This update aims to streamline the setup process and improve multilingual accessibility, benefiting a diverse range of users.

- Added an "Advanced Configuration Options" step to the config flow.
- Moved `action_debug` and `hide_non_standard_entities` configurations to the new step.
- Introduced a checkbox "Show Advanced Configuration Options" in the devices filter form.
- Only show the advanced step if the user opts in via the checkbox.

This change enhances the configuration process by allowing users to access advanced settings only if needed, keeping the initial setup simple.
…PT-BR, RU, and Traditional Chinese.

These translations were generated using Tongyi Lingma and may require further verification to ensure accuracy. Contributions for reviewing and improving these translations are highly appreciated.
# Conflicts:
#	custom_components/xiaomi_home/config_flow.py
@JimmyKmi JimmyKmi changed the title Add Advanced Configuration and Initial Translations feat: Add Advanced Configuration and Initial Translations Dec 18, 2024
- Shortened lines in custom_components/xiaomi_home/config_flow.py to comply with PEP 8's line length limit (80 characters).
- Addressed pylint warnings concerning line lengths on lines 489, 568, and 569.
@JimmyKmi
Copy link
Author

Force-pushed: The commit c997f22 included unnecessary code formatting changes. These have been reverted and the changes have been re-pushed as d8e6c45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant