Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support italian translation #183

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat: support italian translation #183

merged 4 commits into from
Jan 17, 2025

Conversation

wilds
Copy link
Contributor

@wilds wilds commented Dec 18, 2024

No description provided.

@wilds wilds force-pushed the patch-1 branch 2 times, most recently from ca71153 to e1029bb Compare December 18, 2024 16:45
@topsworld topsworld changed the title [FEAT] italian translation feat: support italian translation Jan 10, 2025
@topsworld
Copy link
Contributor

@wilds Thank you for your contribution. Could you please update the translation according to the latest mainline version?

@wilds
Copy link
Contributor Author

wilds commented Jan 14, 2025

@wilds Thank you for your contribution. Could you please update the translation according to the latest mainline version?

Done!

@topsworld
Copy link
Contributor

In /translations, some keys in it.json do not match. Please fix it.

test/check_rule_format.py:253: AssertionError
------------------------------ Captured log call -------------------------------
INFO     check_rule_format:check_rule_format.py:140 inconsistent key values, dict_keys(['eula', 'auth_config', 'network_detect_config', 'oauth_error', 'homes_select', 'advanced_options', 'devices_filter']), dict_keys(['eula', 'auth_config', 'oauth_error', 'devices_filter'])
INFO     check_rule_format:check_rule_format.py:146 inconsistent key values, dict, step
INFO     check_rule_format:check_rule_format.py:146 inconsistent key values, dict, config
INFO     check_rule_format:check_rule_format.py:251 compare_dict_structure failed /translations, it.json
=========================== short test summary info ============================
FAILED test/check_rule_format.py::test_miot_lang_integrity - assert False
================== 1 failed, 6 passed, 1 deselected in 0.06s ===================
Error: Process completed with exit code 1.

@topsworld topsworld merged commit bf116e1 into XiaoMi:main Jan 17, 2025
5 checks passed
@SusanPhevos
Copy link
Contributor

@wilds
Dear contributor,
Thanks for your contribution to ha_xiaomi_home. When you submitted your pull request, the Contributor License Agreement (CLA) of ha_xiaomi_home was not ready. We sincerely hope that you sign the CLA to ensure that all of your past and future contributions to ha_xiaomi_home are legally authorized.
Please view the CLA at https://cla-assistant.io/xiaomi/ha_xiaomi_home and click "Sign in with GitHub to agree" button to sign it.
Thanks again for your support!
ha_xiaomi_home Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants