You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because they do not contribute to the topic at hand. In this case of the PR the comments does not add to the review of the changes. So create seperate issues.
I'm quicker to mark your comment as off topic because you have proven yourself to me to quickly "take over" discussions with a huge wall of text.
If you don't like my ideas, just ignore them.
I will still have to read through them, same for other reviewers. So to save them the work, i mark is as off-topic. Also if you want to revisit the PR you would also have to read them again
You are not the PR author here.
Yes im not, but the PR author also can't do it, because they don't have write access.
That is their view.
My view is that this is a first time contributor, so in order to provide an easier way to their first successfull PR,
I will take an aggressive stance towards unrelated stuff on which they could get sidetracked and which are not required in order to get the PR merged.
In this case you can create a seperate issue and tag them, in order to inform them and they can decide if they want to do it after their PR is merged.
Yes im not, but the PR author also can't do it, because they don't have write access.
Sorry, I didn't know that. Several devs reacted at me in several ways. So, I couldn't figure out what to say.
Just for your kind information, the linked issue TeamNewPipe#6187 asks for the same feature in history as well. I am not sure if it should be solved right now or let users open another issue as well. It's the same feature just in a separate place.
Thanks for your quick reply and all the information 👍.
Ok, i missed that the issue was for both history and playlist.
That is problematic now, because when the PR is merged, the issue can't be closed because there are 2 things in the issue, one of which is not solved by the PR.
But let that be a problem when it actually comes to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SameenAhnaf
Because they do not contribute to the topic at hand. In this case of the PR the comments does not add to the review of the changes. So create seperate issues.
I'm quicker to mark your comment as off topic because you have proven yourself to me to quickly "take over" discussions with a huge wall of text.
I will still have to read through them, same for other reviewers. So to save them the work, i mark is as off-topic. Also if you want to revisit the PR you would also have to read them again
Yes im not, but the PR author also can't do it, because they don't have write access.
That is their view.
My view is that this is a first time contributor, so in order to provide an easier way to their first successfull PR,
I will take an aggressive stance towards unrelated stuff on which they could get sidetracked and which are not required in order to get the PR merged.
In this case you can create a seperate issue and tag them, in order to inform them and they can decide if they want to do it after their PR is merged.