cmd/anubis: add rule hashes for admin-configured denials #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #695 Signed-off-by: Xe Iaso <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds rule hash generation for admin-configured denial rules and updates the HTTP response handling based on the rule hash.
- Added a loop in main to display rule error IDs by computing SHA256 hashes of denied rules.
- Updated the check function to return both a CheckResult and a pointer to the matched Bot, and adjusted the reverse proxy logic accordingly.
- Incremented the templ version in the index template file.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/anubis/main.go | Adds rule hash printing and updates reverse proxy logic to use rule hashes for denied requests. |
| cmd/anubis/policy.go | Introduces Bot.Hash and modifies the check function to return a Bot pointer. |
| cmd/anubis/index_templ.go | Updates templ version to a newer release. |
This won't actually happen in real life, but the code paths might change so we should be somewhat defensive. Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695 and addresses a Gnome infrastructure issue by giving users more information without revealing our hand too much.