Starting with Rust documentation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xe
requested changes
Sep 14, 2018
cwa/olin/src/lib.rs
Outdated
| extern crate chrono; | ||
|
|
||
| use std::io::{self, Read, Write}; | ||
|
|
||
| /// import HTTP client from local | ||
| /// TODO: couldn't get how this is used as it seems not to be called anywhere |
There was a problem hiding this comment.
There was a problem hiding this comment.
so it is not used in lib.rs?
|
Changes applied as per review |
- reference the CWA spec by linking to it in all relevant places - remove places where comments tell you what the type system is telling you - remove unhelpful comments
Xe
approved these changes
Sep 14, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the objectives stated in #43 (comment)
This change is