ci: Install lld explicitly on macOS #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, but before merging I'd like to see the commit title changed to something that is a little more descriptive and follows the pattern of the commit titles we currently have in nxdk, I suggest something like |
ReenigneArcher
changed the title
ReenigneArcher
force-pushed
the
ci/macos/fix-missing-dependency
branch
from
426a944 to
e77b13c
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build for macOS is currently failing due to missing
llddependency.Note: If it's preferable I can combine my PRs into one, although it's probably easier to review them separately. Just let me know whatever you prefer.