Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement
direct.h
functions #636base: master
Are you sure you want to change the base?
Implement
direct.h
functions #636Changes from 6 commits
680b892
18c6acf
0b37066
e2f40bf
72ae765
aa89850
8893c02
6078f61
a5e09e0
cd71cb3
21fe551
57cded3
5ef78d2
014d662
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's alot of cases that are not covered from
GetLastError()
. ERROR_DISK_FULL or ERROR_FILENAME_EXCED_RANGE is just an obvious example.Although these will fail, errno will not be set. Not sure if thats a problem. Comment applies to rmdir too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
ERROR_ALREADY_EXISTS
a valid error code forRemoveDirectoryA
?