winapi improvements #2 #154
Conversation
thrimbor
force-pushed
the
winapi_improved_2
branch
from
565fa32 to
4c08b9e
Compare
thrimbor
force-pushed
the
winapi_improved_2
branch
from
4c08b9e to
a595068
Compare
thrimbor
force-pushed
the
winapi_improved_2
branch
from
a595068 to
d5a0534
Compare
|
Now rebased onto master to fix conflicts. |
| @@ -55,13 +55,14 @@ typedef LONG NTSTATUS; | |||
| #define STATUS_INVALID_HANDLE ((NTSTATUS)0xC0000008L) | |||
| #define STATUS_HANDLE_NOT_CLOSABLE ((NTSTATUS)0xC0000235L) | |||
|
|
|||
| #define WAIT_FAILED ((NTSTATUS)0xFFFFFFFFL) | |||
| #define WAIT_FAILED ((NTSTATUS)0xFFFFFFFFL) // FIXME: Not really an NTSTATUS | |||
There was a problem hiding this comment.
What's there to FIXUP here? Consider splitting this off by an empty line and explaining the situation in a comment (if necessary).
There was a problem hiding this comment.
The fix would be to remove WAIT_FAILED from the kernel headers, but PDCLib currently expects it to be there.
There was a problem hiding this comment.
Where should it be? Why can't we move it?
There was a problem hiding this comment.
Oh I see - it's in the synchapi stuff, but we can't update PDCLib (to find it), because we'd also pull other PDCLib changes if we update the submodule.
| @@ -2111,6 +2080,8 @@ XBAPI VOID NTAPI RtlInitializeCriticalSection | |||
| IN PRTL_CRITICAL_SECTION CriticalSection | |||
| ); | |||
|
|
|||
| #define RtlDeleteCriticalSection(CriticalSection) ((void)CriticalSection) | |||
There was a problem hiding this comment.
This macro still feels dangerous for when CriticalSection is some address math (unlikely, but also shows the problem of macros).
Not sure if an static-function is much better though.
thrimbor
force-pushed
the
winapi_improved_2
branch
from
d5a0534 to
98c5395
Compare
|
I've looked at the code, found nothing odd that's not already pointed out and those parts have been explained already. Lgtm. 👍 |
|
Somehow CI broke for this on merge: https://travis-ci.org/XboxDev/nxdk/jobs/589441844 |
Based on #150 (will rebase once that one is merged to solve conflicts).Most of these commits were done as part of my work to port libc++, but
GetTickCount()andGetSystemInfo()were added to reduce nxdk-specific changes to PDCLib's dlmalloc-port (with a few more enhancements to nxdk, it can now build as it does on Win32 without changes).GetThreadId(),GetCurrentThreadId(),Sleep()andSleepExwere tested separately.