vp20compiler: Forward comments from input to output #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final vs.inl currently doesn't contain the VS variable / constant locations that the Cg vertex program uses. That's an issue as it's necessary to set up a working program.
This adds a small loop, which collects all comments, and forwards them from input to output.
Unfortunately, this is not position aware, so it won't interleave encoded instructions and comments. But it's still good enough to read back the
#var
and#const
lines.It isn't really secure, and it's probably easy to write malicious code which outputs garbage C code (like introducing
/*
as part of the comment).Ideally we'd parse only those important lines and generate a
float c[][4];
and code which uploads it; however, this will have to do for now.This was barely tested, but should work fine.
As an alternative for this PR, we could also remove the deletion step for the intermediate shader files.