audio: Inherit dummy driver as xbox driver #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this fails:
SDL_Init(SDL_INIT_AUDIO)
.This shouldn't happen as I already added dummy drivers in #9.
Unfortunately, it was incomplete (which I didn't know at the time).
There were 2 independent problems which break SDL audio:
SDL_AUDIO_DISABLED 1
with a misleading comment (implying the dummy would be active); it should beSDL_AUDIO_DRIVER_DUMMY
.demand_only = 1
. This means will be rejected unless explicitly requested through environment variables (which are alwaysNULL
in nxdk at the moment).As a solution, I add a source file which includes the dummy driver; however, the dummy backend with
demand_only = 1
is never registered itself.Instead it is registered as another backend ("xbox") with
demand_only = 0
.Accordingly, I use
SDL_AUDIO_DRIVER_XBOX
in our config.I'm not sure about the commit title - suggestions welcome.
I have smoke-tested this by using this in the SDL sample
main
function:(needs
#include <assert.h>
)Please confirm that this works correctly (my nxdk and SDL trees also had other changes at the time).