Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XBox: Fix align_val_t in include/new #8

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Conversation

glebm
Copy link

@glebm glebm commented Jul 1, 2022

@glebm
Copy link
Author

glebm commented Jul 2, 2022

This only fixes the declarations but there is nothing to actually link them against.

The built-in C++ aligned allocation is not defined:

lld: error: undefined symbol: void * __cdecl operator new(unsigned int, enum std::align_val_t)

Neither are _aligned_malloc and posix_memalloc.

@glebm
Copy link
Author

glebm commented Jul 3, 2022

Updated the patch.

It now works together with XboxDev/nxdk-pdclib#52 and XboxDev/nxdk#603 🎉

@glebm glebm marked this pull request as ready for review July 3, 2022 21:59
@glebm
Copy link
Author

glebm commented Jul 7, 2022

@Ryzee119 This needs to be merged as well to fully enable aligned_alloc (and submodule needs to be bumped in nxdk)

@thrimbor
Copy link
Member

Appears to work fine, merging

@thrimbor thrimbor merged commit 3111bbf into XboxDev:nxdk Jul 16, 2022
@glebm glebm deleted the patch-1 branch July 16, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

error: no type named 'align_val_t' in namespace 'std'
2 participants