-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phantombot package invalid download and install dir param request #19
Comments
Hi @Destroy666x 🙂 Thank you a lot for creating this issue! I have corrected the error in the About the second point, do you have some example of package that have the feature |
Thanks. I do indeed. Many Chocolatey packages in the official community repository have it, for instance. Few examples:
It's mostly nice to have for apps that don't use standard install locations such as |
Hi @Destroy666x, I have create a Pull Request #30 with the modification on the Feel free to comment on the Pull Request #30, if you see an error, something missing, or if everything looks fine to you 😉 |
Thanks, looks good, I'll check if it works fine later It indeed does |
Custom installation folder for PhantomBot package. Adds the capacity to specify a parameter '/InstallDir' in order to change the default installation directory. Fixes #19.
Hi,
1st of all, the package has a big issue of downloading the wrong release. This regex is incorrect: https://github.com/Xav83/chocolatey-packages/blob/develop/automatic/phantombot/update.ps1#L21 It assumes any kind of release basically and gets the 1st one, so
PhantomBot-3.7.0.1-arm-bsd-other.zip
in case of current version instead of properPhantomBot-3.7.0.1-win.zip
. The regex should includewin
and escape the extension dot like\.
. So:$re = "PhantomBot.+win\.zip$"
Secondly, it would be nice if we could override the unzip location. So something like
/InstallDir
param that's available in many Chocolatey community packages would be handy.The text was updated successfully, but these errors were encountered: