Replace std::terminate with throw #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Report (Ubuntu)0 files 0 suites 0s ⏱️ Results for commit 11b1d8c. |
Test Report (MacOS)0 files 0 suites 0s ⏱️ Results for commit 11b1d8c. |
Mandrenkov
requested changes
May 13, 2021
brownj85
suggested changes
May 13, 2021
brownj85
approved these changes
May 18, 2021
Mandrenkov
requested changes
May 18, 2021
There was a problem hiding this comment.
Awesome work on the refactoring and the tests! This is a nice improvement over the first iteration.
In addition to the in-situ review comments, I would also suggest creating a Test_Abort.cpp file with a simple unit test to verify the format of an abort exception message.
Finally, don't forget to append this change to CHANGELOG.md!
Mandrenkov
approved these changes
May 19, 2021
* Switch multi-index to row-major order * Replace 'utilities' tag with 'Utilities' * Fix tests specifying indices in column-major order * Update changelog * Fix Python unit test using column-major indices * Undo modification to previous changelog entry * Fix PR number
Mandrenkov
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The
Abort.hppheader defines a series of macros that callstd::terminatein the event of an unfavourable state or event in Jet. This will cause problems with the Python bindings, and kill the Python session is such a state or event is encountered.Description of the Change: This PR replaces
std::terminatewith a thrown exception defined by the error message.Benefits: This will prevent the Python session being terminated in the event of a call to any of the
Abort.hppmacros.Possible Drawbacks: None
Related GitHub Issues: None