Disambiguate tensor specializations in Python bindings #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
approved these changes
May 26, 2021
thisac
approved these changes
May 26, 2021
mlxd
approved these changes
May 27, 2021
Ah, yes. Thanks for catching that! |
Mandrenkov
added a commit
that referenced
this pull request
May 27, 2021
* add ir * move tests * run black * Rename ir/ directories to xir/ * Apply formatter and update import paths * Clarify that top-level makefile is for C++ code * Rename Python bindings package to 'bindings' * Move Python bindings tests to subdirectory * Update import path to Python bindings module * Rename 'requirements_test.txt' to 'requirements.txt' * Add Python wheel dependencies * Add Python distribution directory to .gitignore * Create top-level Jet Python package * Create setup.py to build quantum-jet Python wheels * Move setup.py to python/ directory * Make cleaned directory prefixes consistent * Add 'build' help documentation and clean build/ and dist/ * Change source directory to parent directory * Import all bindings directly into the 'jet' package * Exclude tests from package * Fix wheel build error for lark * Remove deprecated Python bindings build steps * Update changelog * Adjust PR number * Flatten jet.bindings package and apply formatter * Change 'lark' requirement to 'lark-parser' * Disambiguate tensor specializations in Python bindings (#15) * Rename 'Foo64' to 'FooC128' and 'Bar32' to 'BarC64' * Update changelog * Clarify that specializations are for complex types in changelog * Replace 'c_fp32' with 'c_fp64' with 'c64' and 'c128', respectively * Update Python comment explaining default Jet types * Replace 'Tensor64' with 'Tensor' in example docstrings Co-authored-by: Theodor Isacsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Each template specialization of the
Tensorclass requires a unique name for its Python binding. Previously, the convention was to add a32suffix forcomplex<float>specializations and a64suffix forcomplex<double>specializations; however, this is easy to confuse with the (yet-to-be implemented)floatanddoublespecializations.Description of the Change:
C64andC128instead of32and64, respectively.Benefits:
Possible Drawbacks:
Related GitHub Issues:
None.