-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IR to Jet #11
Add IR to Jet #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good!
As a follow-up to our meeting, we should:
- Update the formatter to comply with the standards set by SF and PL. Use
make format
to run the formatter locally. - Ensure the Python tests pass in the CI environment.
- Add the required dependencies to
requirements.txt
(orrequirement_test.txt
). - (Future PR) Migrate the IR user guide to the "Using Jet" section of the documentation (
docs/use
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and don't forget to update the changelog before you merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Theo! I only ask that you address Josh's comment before merging.
Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Mikhail Andrenkov <[email protected]>
Adds the IR to Jet, stored in
python/ir
. This folder contains the following:grammar.md
in the IR repo) describing the syntax of the IR.To-do/To-discuss
python/tests
)usage_guide.md
to fit better with Jet.strawberryfields
andlark
to requirements.