Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute Balea only in specific authentication schemes #13

Merged
merged 7 commits into from
May 1, 2020
Merged

Execute Balea only in specific authentication schemes #13

merged 7 commits into from
May 1, 2020

Conversation

hbiarge
Copy link
Collaborator

@hbiarge hbiarge commented Apr 25, 2020

Fix #12.

@hbiarge hbiarge requested a review from lurumad April 25, 2020 07:18
@lurumad
Copy link
Collaborator

lurumad commented Apr 26, 2020 •
edited by hbiarge
Loading

Hi @hbiarge

Thanks for your contribution! I've reviewed the PR and we have some TODOs:

  • Samples are not working.
InvalidOperationException: Cannot consume scoped service 'Balea.BaleaOptions' from singleton 'Microsoft.AspNetCore.Mvc.ApplicationModels.ApplicationModelFactory'.
  • UnauthorizedFallback is not working
  • Needs docs for the configuration schemes.

Regards!

@lurumad lurumad added this to the v3.0.0 milestone Apr 27, 2020
@lurumad lurumad added the enhancement New feature or request label Apr 27, 2020
@lurumad lurumad merged commit 84841e1 into master May 1, 2020
@lurumad
Copy link
Collaborator

lurumad commented May 1, 2020

Thanks for your contribution @hbiarge

@hbiarge hbiarge deleted the hbiarge/authentication-schemes branch May 10, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurumad lurumad Awaiting requested review from lurumad

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Execute Balea only in the specified authentication schemes
2 participants
@hbiarge @lurumad