Skip to content

Remove unnecessary precondition checks #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Dec 18, 2023
Merged

Remove unnecessary precondition checks #2129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87d0dbd
Remove unnecessary precondition checks.
bgrainger Dec 16, 2023
ae5082f
Simplify constructor.
bgrainger Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/HealthChecks.MySql/MySqlHealthCheck.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ public class MySqlHealthCheck : IHealthCheck
public MySqlHealthCheck(MySqlHealthCheckOptions options)
{
Guard.ThrowIfNull(options);
Comment thread
bgrainger marked this conversation as resolved.
Outdated
if (options.DataSource is null && options.ConnectionString is null)
throw new InvalidOperationException("One of options.DataSource or options.ConnectionString must be specified.");
if (options.DataSource is not null && options.ConnectionString is not null)
throw new InvalidOperationException("Only one of options.DataSource or options.ConnectionString must be specified.");
_options = options;
}

Expand Down