Skip to content

Change PinnedPeerCertSha256 from array to tilde-separated string #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RPRX merged 5 commits into from
Jan 9, 2026
Merged

Change PinnedPeerCertSha256 from array to tilde-separated string #5507

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
faed35d
Initial plan
Copilot Jan 8, 2026
34f21e9
Change PinnedPeerCertSha256 from array to pipe-separated string
Copilot Jan 8, 2026
7ee4bd4
Use string instead of *string and remove trailing space in JSON tag
Copilot Jan 8, 2026
9e37c29
Replace separator from pipe (|) to underscore (_)
Copilot Jan 8, 2026
5a66c40
Replace separator from underscore (_) to tilde (~)
Copilot Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions infra/conf/transport_internet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ type TLSConfig struct {
CipherSuites string `json:"cipherSuites"`
Fingerprint string `json:"fingerprint"`
RejectUnknownSNI bool `json:"rejectUnknownSni"`
PinnedPeerCertSha256 *[]string `json:"pinnedPeerCertSha256 "`
PinnedPeerCertSha256 string `json:"pinnedPeerCertSha256"`
CurvePreferences *StringList `json:"curvePreferences"`
MasterKeyLog string `json:"masterKeyLog"`
ServerNameToVerify string `json:"serverNameToVerify"`
Expand Down Expand Up @@ -457,9 +457,15 @@ func (c *TLSConfig) Build() (proto.Message, error) {
}
config.RejectUnknownSni = c.RejectUnknownSNI

if c.PinnedPeerCertSha256 != nil {
if c.PinnedPeerCertSha256 != "" {
config.PinnedPeerCertSha256 = [][]byte{}
for _, v := range *c.PinnedPeerCertSha256 {
// Split by tilde separator
hashes := strings.Split(c.PinnedPeerCertSha256, "~")
for _, v := range hashes {
v = strings.TrimSpace(v)
if v == "" {
continue
}
hashValue, err := hex.DecodeString(v)
if err != nil {
return nil, err
Expand Down