Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
buf最好别动 只是 Compact 函数的问题 还是我来修吧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the lack of error return in the two functions
readandwrite(inbuffer.go) caused the author to write the functionCompact(inmulti_buffer.go) incorrectly and no one has noticed until now.///
common.Must2(last.ReadFrom(curr))does not necessarily appendcurrtolast, alsocommon.Must2has no effect here, becauseReadFromdoes not return any error on failure.///
for example suppose:
in
Compactfunctionforloop,last==mb[0]andcurr==mb[1]and
last.start==2andlast.end==8192and
curr.start==0andcurr.end==2so
last.Len() + curr.Len() <= 8192but
common.Must2(last.ReadFrom(curr))doesn't actually do anything!!!///
Compactfunction is used intlsandwebsocket, and this caused the Xray-core to occasionally send corrupted data for almost all users!!! Whoa!!!thanks to @Vdu6n1XMrq6694a8 for his/her great Reproduction.