Skip to content

Vless fallback: we shoud not create fallback-connection after inbound-connection is closed#4911

Closed
patterniha wants to merge 1 commit intoXTLS:mainfrom
patterniha:fallback
Closed

Vless fallback: we shoud not create fallback-connection after inbound-connection is closed#4911
patterniha wants to merge 1 commit intoXTLS:mainfrom
patterniha:fallback

Conversation

@patterniha
Copy link
Collaborator

@patterniha patterniha commented Jul 19, 2025

first do the following test to understand better:

  1. run this xray config

  2. sniff loopback port 8888 with wireshark

  3. run this python script
    this script create a connection to xray-vless-inbound and close the connection after 1 seconds

you see after inbound-connection is closed, xray create a connection to fallback and then close it immediately!!!

this is just a waste and should be fixed.

Screenshot 2025-07-19 170558

@Fangliding
Copy link
Member

等其他的合并吧别发这些有的没的了 谁没事打堆syn flood

@Fangliding Fangliding closed this Jul 19, 2025
@patterniha
Copy link
Collaborator Author

What does it have to do with syn-flood?
in many situations connection is closed before receiving any data.

CC @RPRX

@patterniha
Copy link
Collaborator Author

all other protocols trojan/socks... return error when reading the first data is unsuccessful:

firstLen, err := first.ReadFrom(conn)
if err != nil {
return errors.New("failed to read first request").Base(err)
}

this is forgotten by the author for vless, and should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants