feat: add new method for get only inbound tags from core. ListTags.#4862
Closed
Jolymmiles wants to merge 2 commits intoXTLS:mainfrom
Closed
feat: add new method for get only inbound tags from core. ListTags.#4862Jolymmiles wants to merge 2 commits intoXTLS:mainfrom
Jolymmiles wants to merge 2 commits intoXTLS:mainfrom
Conversation
Contributor
Author
|
@Fangliding Could you look pls? |
Member
|
我不觉得listTags有什么很大用处 这个command列表已经有点乱了 |
Contributor
So it is okay that similar method exists already? I mean this PR #4723. It can be used for similar purposes, but... it is much simpler and much cheaper to get just TAGS without all that stuff like all users, which is not needed mostly |
Member
|
正是因为已经有了类似的所以我才觉得没必要再加一个这样的 而且那个pr的功能更全面 而且我确实没有想到列出tag的意义在哪 |
Member
|
否则会导出很多类似的乱七八糟的东西 比如输出dns服务器tag 路由规则tag 诸如此类。。 不可能给每一个小项单开一个API |
Contributor
Author
|
@Fangliding ok, but what if it is an option of an existing method? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new method to get only tags from core instead full inbounds body with a lot of users.
#4723 (comment)