Sniffer bug: fakedns alone should not override domain for tls/http/quic (when there is no map-domain)#4733
Closed
patterniha wants to merge 1 commit intoXTLS:mainfrom
patterniha:fix-bug9
Closed
Sniffer bug: fakedns alone should not override domain for tls/http/quic (when there is no map-domain)#4733patterniha wants to merge 1 commit intoXTLS:mainfrom patterniha:fix-bug9
fakedns alone should not override domain for tls/http/quic (when there is no map-domain)#4733patterniha wants to merge 1 commit intoXTLS:mainfrom
patterniha:fix-bug9
Conversation
fakedns should not override domain for tls/http/quic when there is no map-domain.fakedns should not override domain for tls/http/quic (when there is no map-domain)
fakedns should not override domain for tls/http/quic (when there is no map-domain)fakedns alone should not override domain for tls/http/quic (when there is no map-domain)
Member
|
This is a feature I developed, not a bug. I had discussion with Fangliding. |
Collaborator
Author
But it is not equal to ["http", "tls", "quic", "fakedns"]
But this is not correct: #4726 (comment), #4726 (comment) /// The documentation says two contradictory things, neither of which is correct !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently,
"destOverride": ["fakedns"]override domain for tls/http/quic protocol when ip is in fake-pool-range and when we have no map-domain.This shouldn't happen and this is
fakedns+othersjob.///
also, it seems
fakedns+othershas no practical use and can be removed later.